Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parser] Go back to "sub final" intead of "sub open" #6199

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

tlively
Copy link
Member

@tlively tlively commented Jan 3, 2024

The planned spec change to use "sub open" never came together, so the standard
format remains "sub final".

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a link to that discussion?

@tlively
Copy link
Member Author

tlively commented Jan 3, 2024

Discussion here: WebAssembly/gc#423

Base automatically changed from parser-input-annotations to main January 3, 2024 22:04
The planned spec change to use "sub open" never came together, so the standard
format remains "sub final".
@tlively
Copy link
Member Author

tlively commented Jan 3, 2024

Merge activity

  • Jan 3, 5:05 PM: Graphite rebased this pull request as part of a merge.
  • Jan 3, 5:32 PM: @tlively merged this pull request with Graphite.

@tlively tlively merged commit 1878403 into main Jan 3, 2024
15 checks passed
@tlively tlively deleted the parser-final branch January 3, 2024 22:32
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
The planned spec change to use "sub open" never came together, so the standard
format remains "sub final".
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants