Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename memory-copy-fill-lowering pass #7082

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Rename memory-copy-fill-lowering pass #7082

merged 1 commit into from
Nov 16, 2024
+23 −23

Conversation

dschuff
Copy link
Member

@dschuff dschuff commented Nov 15, 2024 •
edited
Loading

Since the resulting code has the same undefined behavior as LLVM, make the pass name reflect that.

@dschuff dschuff requested a review from aheejin November 15, 2024 18:18
@dschuff dschuff mentioned this pull request Nov 15, 2024
Open
@dschuff dschuff enabled auto-merge (squash) November 15, 2024 18:25
aheejin
aheejin approved these changes Nov 16, 2024
View reviewed changes
Copy link
Member

@aheejin aheejin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but can this be made into a parallel pass like #7016? (There are tasks that have to be performed by the module level but it looks the code transformation could be performed in parallel)

@dschuff dschuff merged commit 69591de into main Nov 16, 2024
13 checks passed
@dschuff dschuff deleted the rename-copy branch November 16, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aheejin aheejin aheejin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dschuff @aheejin