-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update testsuite #2495
Update testsuite #2495
Conversation
BTW, the reason for this is that memory64 is based on the wasm-3.0 branch of the spec repo where those proposals are already merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks @keithw
lgtm % comments
Makes sense -- I think this is going to become more painful for WABT over time as more proposals go this direction (at least until WABT implements function-references+gc or is refactored on top of wasm-tools or binaryen). It's caused some issues in the https://github.com/WebAssembly/testsuite/ repo; e.g. memory64 doesn't change |
Ah yes, I guess we should modify update-testsuite.sh in the test suite repo so that it is aware that not all proposals forked from main. |
This means that the memory64 proposal now only contains that tests that differe from its upstream branch which is wasm-3.0, instead of including basically all test files. See WebAssembly/wabt#2495
Can we remove |
sure! |
This means that the memory64 proposal now only contains that tests that differe from its upstream branch which is wasm-3.0, instead of including basically all test files. See WebAssembly/wabt#2495
The memory64 `table.wast` test has started to depend on function-references and gc (which WABT doesn't support yet), so vendor an older version of the test.
d96bd73
to
fe6b537
Compare
Done. |
The memory64
table.wast
test has started to depend on function-references and gc (which WABT doesn't support yet), so vendor an older version of the test.