Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioContext "interrupted" state #2611

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

gabrielsanbrito
Copy link

@gabrielsanbrito gabrielsanbrito commented Nov 9, 2024

This PR adds the specification to the AudioContext "interrupted" state. This change does not have Web Platform Tests, because web pages are not able to trigger interruptions themselves. Starting an interruption is a prerogative of the user agent.

Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/AudioContextInterruptedState/explainer.md


Preview | Diff

@hoch hoch requested review from hoch and padenot November 14, 2024 17:07
@hoch
Copy link
Member

hoch commented Nov 14, 2024

FYI @youennf - here's the interrupted state spec work for AudioContext.

@gabrielsanbrito gabrielsanbrito marked this pull request as ready for review November 21, 2024 00:40
@hoch hoch requested a review from mdjp December 12, 2024 17:19
@mjwilson-google mjwilson-google added Agenda+ Should be discussed at the next WG meeting. https://speced.github.io/spec-maintenance/about/ and removed Agenda+ Should be discussed at the next WG meeting. https://speced.github.io/spec-maintenance/about/ labels Feb 18, 2025
Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. I have some comments on style/formatting.

@hoch
Copy link
Member

hoch commented Feb 24, 2025

@gabrielsanbrito You don't have to correct all instances in the entire document, but I think it makes sense to clean up the section (e.g. this specific algorithm) that we're working on.

Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

Let's wait for the review from @padenot, @chrisguttandin, or @mdjp. I think we can merge when we have one more +1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants