-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AudioContext "interrupted" state #2611
base: main
Are you sure you want to change the base?
AudioContext "interrupted" state #2611
Conversation
FYI @youennf - here's the interrupted state spec work for AudioContext. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good. I have some comments on style/formatting.
@gabrielsanbrito You don't have to correct all instances in the entire document, but I think it makes sense to clean up the section (e.g. this specific algorithm) that we're working on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits
Let's wait for the review from @padenot, @chrisguttandin, or @mdjp. I think we can merge when we have one more +1.
This PR adds the specification to the AudioContext "interrupted" state. This change does not have Web Platform Tests, because web pages are not able to trigger interruptions themselves. Starting an interruption is a prerogative of the user agent.
Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/AudioContextInterruptedState/explainer.md
Preview | Diff