-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move source-code fonts to new build workflow #13093
Move source-code fonts to new build workflow #13093
Conversation
Changes Include: - Removed the old scripts/yarn/** dir, as it is no longer needed. - Moved source-code-pro and source-sans to client/ - Built and bundled the fonts. - Updated templates to use the new built fonts and styles. - Added new built bundles license info in REUSE.toml. Note: - The old bundles did not get removed to keep this PR simple for review. TODO: - Remove old fonts bundles. - Update any dependents on them to use the new bundles. - if FONTS_CDN_URL is configured it should be seted up with static/js/vendor/fonts instead of the old font-source/ - Remove the old yarn-update workflow and its configs and workflows Related: WeblateOrg#12172
weblate/static/js/vendor/fonts/font-source/07e9568bc36099d13146.woff2
Outdated
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
This avoids silent breakages on changes like #13093.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs/conf.py
also needs to be changed to use the new location of the fonts. I've made the docs build fail when the fonts directory doesn't exist in 425131e.
- Update docs/conf.py - Update test_selenium.py
@nijel I rerun the test suite on summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13093 +/- ##
==========================================
- Coverage 90.97% 90.95% -0.03%
==========================================
Files 599 601 +2
Lines 62058 62390 +332
Branches 6397 6453 +56
==========================================
+ Hits 56457 56744 +287
- Misses 3944 3974 +30
- Partials 1657 1672 +15
|
Merged, thanks! I've made a fix to the testsuite (and reverted unnecessary changes there). |
And I didn't notice messed up licensing info, fixed that now in 1781de2. |
I've created a followup issue at #13255. Using webpack is better than what we had before, but we might need something different in the end. |
Proposed changes
Moved source-code fonts to new build workflow
Changes Include:
scripts/yarn/**
dir, as it is no longer needed.source-code-pro and source-sans
toclient/
REUSE.toml
.Note:
TODO:
FONTS_CDN_URL
is configured it should be seted up withstatic/js/vendor/fonts
instead of the oldfont-source/
yarn-update
script and its configs and workflowsRelated: #12172
Checklist
Other information