refactor the code phase1 NEEDS DISCUSSIONS #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
eimaam
requested changes
Jul 15, 2024
src/controllers/node.controller.ts
Outdated
| count = searchResult.count; | ||
| } | ||
|
|
||
| res.status(201).json({ nodes, count }); |
There was a problem hiding this comment.
the right status code here should be 200 as 201 is for creating new resource.
Can we update that pls.
Suggested change
| res.status(201).json({ nodes, count }); | |
| res.status(200).json({ nodes, count }); |
src/dao/api.dao.ts
Outdated
Comment on lines
29
to
32
| console.log("====imgs===", images); | ||
| console.log(name); | ||
| console.log(userId); | ||
| console.log("===rest===", rest); |
There was a problem hiding this comment.
Lets do away with the logs if not needful.
| console.log("===rest===", rest); | ||
| const createdClaim = await prisma.claim.create({ | ||
| data: { | ||
| issuerId: `http://trustclaims.whatscookin.us/users/${userId}`, |
There was a problem hiding this comment.
Recommending we store the baseURL (https://trustclaims.whatscookin.us) used in the issuerId here in an environment variable. This would enhance maintainability by enabling us to modify the URL centrally in case of future changes (e.g., domain migration, API updates) etc...
| edgesTo: { | ||
| some: { | ||
| claim: { | ||
| issuerId: `http://trustclaims.whatscookin.us/users/${userId}`, |
eimaam
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.