-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add auth with google #132
Conversation
You have to push the database first |
}); | ||
|
||
if ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this IF block can be simplified to
if (
alreadyExistingUser &&
email &&
(
!alreadyExistingUser.email ||
alreadyExistingUser.authType !== "GOOGLE" ||
alreadyExistingUser.authProviderId !== googleId ||
alreadyExistingUser.name !== name
)
) {
...
}
unless there is a need to check the existence of both authType and authProviderId simultaneously. and existence of email should also be separately checked since we're updating with it nonetheless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This if will be modified in the next feature depending on the coming logic so it's not a big deal right now
bfa26a8
to
3e7c4d5
Compare
…in/trust_claim_backend into implement-google-auth
…in/trust_claim_backend into implement-google-auth
Description
Please provide a brief summary of the changes in this PR.
Type of Change
Checklist
4- steps to test ?
login with google
Please provide a brief summary of the steps required to test the changes in this PR.
5- results ?
Please provide a brief summary of the results after testing the changes in this PR.
added login with google endpoint
7- screenshots ?
Please provide screenshots of the results after testing the changes in this PR.