Fix/claims-search #135
Merged
Fix/claims-search #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const { page = 1, limit = 100, search = "" } = req.query; // defaults provided here | ||
| let { page = 1, limit = 100, search = "" } = req.query; | ||
|
|
||
| page = parseInt(page.toString()); |
There was a problem hiding this comment.
we can use page = +page here and the other fields instead of using all these methods as it costs somehow
There was a problem hiding this comment.
The cost difference is nothing. I made it this way to avoid floating numbers as +page will include decimals
AhmedAbdelmenam
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
/api/claimsfeed2pagination and performance issues (went from 9+ seconds to ~1.2s).Type of Change
Checklist
4- steps to test?
After running the server hit the
/api/claimsfeed2endpoint with deferent query strings values.5- results?
7- screenshots?
N/A