fixes 500 link limit issue #5595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ragesoss The CI build keeps failing for this pr well as as earlier pr i made, what is the issue in my code i am not able to understand |
|
I tried this locally and got: |
|
@ragesoss this PR is faulty, I forgot to close it as I implemented continue assuming that the api response has a continue field to fetch more results however on inspecting the api response, there is no continue field so I am stumped as to how to apply pagination for more than 500 links. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5588
What this PR does
It fixes the 500 page link limit for the training modules.
Screenshots
Before:
After:
