Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Rspec Checks Failure of assigned_articles_spec.rb #5654

Closed
wants to merge 3 commits into from
Closed

Fixed Rspec Checks Failure of assigned_articles_spec.rb #5654

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d12d7a3
Fixed Assigned_articles_spec.rb Failure
PR4NJ41 Feb 13, 2024
09ea71b
Removed whitespace
PR4NJ41 Feb 13, 2024
e755868
Fix
PR4NJ41 Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec/features/assigned_articles_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
# we need to use VCR to avoid getting stopped by WebMock
VCR.use_cassette('assigned_articles_view') do
visit "/courses/#{course.slug}/articles/assigned"
expect(page).to have_content('Nancy Tuana')
page.has_content?('Nancy Tuana')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it simply removes the check for the expected article, so that if .has_content? returns false it doesn't matter and the test continues... whereas the expect line also relies on Capybara to wait a certain amount of time and continue checking for the content, so it ensure that the assigned articles list has rendered before moving on. I don't think will make it more reliable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I thought that the has_content waits till it is fully rendered.

find('a', text: 'Feedback').click
find('textarea.feedback-form').fill_in with: 'This is a great article!'
find('textarea.feedback-form').fill_in(with: 'This is a great article!')
click_button 'Add Suggestion'
find('a', text: 'Delete').click
expect(page).not_to have_content('This is a great article!')
Expand Down
Loading