-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code migration. #5881
base: master
Are you sure you want to change the base?
code migration. #5881
Conversation
Hey @ragesoss, Please review my pr and let me know if any further changes are required. |
Hey @ragesoss I have made the required changes. |
It looks like the failing specs are related to this component. |
Hey @ragesoss I have made the required changes. |
Hey @ragesoss can you pls guide me, why its causing a coverage run error. |
If you inspect the coverage logs, at the end of the Ruby test suite, you can find the details about which tests failed and why. (In this case, they are feature specs that are failing when they reach the UI for the component you changed.) I recommend running those specific tests locally to learn more. If necessary, you can modify the browser configuration in rails_helper.rb to remove the 'headless' option and watch the tests run in your browser to see exactly what is going wrong. |
NOTE: Please review the pull request process before opening your first PR: https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/CONTRIBUTING.md#pull-request-process
What this PR does
< describe the purpose of this pull request and note the issue it addresses >
The respective pr changes the existing class component to modern react ie. to functional component using hooks.
Screenshots
Before:
![WhatsApp July 2 Image (1)](https://private-user-images.githubusercontent.com/147957109/345598294-6e646f65-3284-4605-a7f7-54fef8519b97.jpeg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMTgyNDUsIm5iZiI6MTczOTAxNzk0NSwicGF0aCI6Ii8xNDc5NTcxMDkvMzQ1NTk4Mjk0LTZlNjQ2ZjY1LTMyODQtNDYwNS1hN2Y3LTU0ZmVmODUxOWI5Ny5qcGVnP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDhUMTIzMjI1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MGZmNDZjYzc5NDJlMTE4ZjE0NjgxYTM0NGQ4ZWU2OTI5Y2ZlNGQ3YTczMTMxY2FkN2I4NzUxYzViOGY3MjRhNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.xmdexetKFSg6TWNdmzPOGMssI9dk93IKkKpRTCijyeg)
< add a screenshot of the UI before your change >
After:
< add a screenshot of the UI after your change >
Open questions and concerns
< anything you learned that you want to share, or questions you're wondering about related to this PR >
![WhatsApp July 3 Image](https://private-user-images.githubusercontent.com/147957109/345598381-0b05cc8c-ac79-48aa-846d-e3879fe76134.jpeg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMTgyNDUsIm5iZiI6MTczOTAxNzk0NSwicGF0aCI6Ii8xNDc5NTcxMDkvMzQ1NTk4MzgxLTBiMDVjYzhjLWFjNzktNDhhYS04NDZkLWUzODc5ZmU3NjEzNC5qcGVnP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDhUMTIzMjI1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MTEyOGMyMGM4NzcyZjI5NzFiYjg0N2U4NDNjODU5MjViYWYwOWVkODJiM2I0NmQyZjlhOTA5YTliMzg3MTUzOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.MS5NBXY5ji98lGjEJR812vy9b2xQa6QQFq9Q-JRnkDU)