Merge pull request #17432 from Wikia/popular-pages-smart-crop

IW | Smart crop in popular pages rail module
Wikia · Aug 30, 2019 · d60c2d3 · d60c2d3
2 parents 19e0819 + e665d39
commit d60c2d3
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/extensions/wikia/Recirculation/RailContentService.php b/extensions/wikia/Recirculation/RailContentService.php
@@ -17,7 +17,7 @@ public function renderRailModule() {
 			try {
 				$articles[$pageId]['thumbnail'] =
 					VignetteRequest::fromUrl( $article['thumbnail'] )
-						->zoomCrop()
+						->smart()
 						->width( static::RAIL_THUMBNAIL_WIDTH )
 						->height( static::RAIL_THUMBNAIL_HEIGHT )
 						->url();

diff --git a/extensions/wikia/Recirculation/js/recirculation.js b/extensions/wikia/Recirculation/js/recirculation.js
@@ -192,7 +192,7 @@ require([
 
 					if (sponsoredItem.thumbnailUrl && window.Vignette) {
 						sponsoredItem.thumbnailUrl = window.Vignette.getThumbURL(sponsoredItem.thumbnailUrl, {
-							mode: window.Vignette.mode.zoomCrop,
+							mode: window.Vignette.mode.smart,
 							height: 53,
 							width: 53
 						});

diff --git a/lib/Wikia/src/Vignette/UrlGenerator.php b/lib/Wikia/src/Vignette/UrlGenerator.php
@@ -21,6 +21,8 @@ class UrlGenerator {
 	const MODE_WINDOW_CROP_FIXED = 'window-crop-fixed';
 	const MODE_ZOOM_CROP = 'zoom-crop';
 	const MODE_ZOOM_CROP_DOWN = 'zoom-crop-down';
+	const MODE_SMART = 'smart';
+
 
 	const IMAGE_TYPE_AVATAR = 'avatars';
 	const IMAGE_TYPE_IMAGES = 'images';
@@ -243,6 +245,10 @@ public function windowCropFixed() {
 		return $this->mode(self::MODE_WINDOW_CROP_FIXED);
 	}
 
+	public function smart() {
+		return $this->mode( self::MODE_SMART );
+	}
+
 	/**
 	 * Force the thumbnail request to replace the cached thumbnail.
 	 *

diff --git a/resources/wikia/libraries/vignette/vignette.js b/resources/wikia/libraries/vignette/vignette.js
@@ -291,6 +291,7 @@ var Vignette = (function () {
 		fixedAspectRatio: 'fixed-aspect-ratio',
 		fixedAspectRatioDown: 'fixed-aspect-ratio-down',
 		scaleToWidth: 'scale-to-width',
+		smart: 'smart',
 		thumbnail: 'thumbnail',
 		thumbnailDown: 'thumbnail-down',
 		topCrop: 'top-crop',