Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only log battery energy warning once per occurrence #612

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Only log battery energy warning once per occurrence #612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions custom_components/solaredge_modbus_multi/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1932,6 +1932,7 @@ def __init__(self, platform, config_entry, coordinator):

self._last = None
self._count = 0
self._log_once = None

@property
def unique_id(self) -> str:
Expand Down Expand Up @@ -1959,21 +1960,26 @@ def native_value(self):

if self._platform.decoded_model["B_Export_Energy_WH"] >= self._last:
self._last = self._platform.decoded_model["B_Export_Energy_WH"]
self._log_once = False

if self._platform.allow_battery_energy_reset:
self._count = 0

return self._platform.decoded_model["B_Export_Energy_WH"]

else:
if not self._platform.allow_battery_energy_reset:
if (
not self._platform.allow_battery_energy_reset
and not self._log_once
):
_LOGGER.warning(
(
"Battery Export Energy went backwards: Current value " # noqa: B950
f"{self._platform.decoded_model['B_Export_Energy_WH']} " # noqa: B950
f"is less than last value of {self._last}"
)
)
self._log_once = True

if self._platform.allow_battery_energy_reset:
self._count += 1
Expand Down Expand Up @@ -2015,6 +2021,7 @@ def __init__(self, platform, config_entry, coordinator):

self._last = None
self._count = 0
self._log_once = None

@property
def unique_id(self) -> str:
Expand Down Expand Up @@ -2042,21 +2049,26 @@ def native_value(self):

if self._platform.decoded_model["B_Import_Energy_WH"] >= self._last:
self._last = self._platform.decoded_model["B_Import_Energy_WH"]
self._log_once = False

if self._platform.allow_battery_energy_reset:
self._count = 0

return self._platform.decoded_model["B_Import_Energy_WH"]

else:
if not self._platform.allow_battery_energy_reset:
if (
not self._platform.allow_battery_energy_reset
and not self._log_once
):
_LOGGER.warning(
(
"Battery Import Energy went backwards: Current value " # noqa: B950
f"{self._platform.decoded_model['B_Import_Energy_WH']} " # noqa: B950
f"is less than last value of {self._last}"
)
)
self._log_once = True

if self._platform.allow_battery_energy_reset:
self._count += 1
Expand Down