Updates for Pymodbus 3.8 #756
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillCodeForCats
added
bug
3 tasks
WillCodeForCats
force-pushed
the
pymodbus_3_8
branch
2 times, most recently
from
8918e61 to
44ba889
Compare
WillCodeForCats
force-pushed
the
pymodbus_3_8
branch
from
ecf5790 to
c287149
Compare
WillCodeForCats
changed the title
Convert a list of 16-bit unsigned integers into a string. Each int is 2 bytes. This method exists because pymodbus ModbusClientMixin.convert_from_registers with data_type=DATATYPE.STRING needs errors="ignore" added to handle SolarEdge strings. Instead we decode the registers as DATATYPE.UINT16 and then use this method to get a string from the list of integers. Ref: https://github.com/pymodbus-dev/pymodbus/blob/7fc8d3e02d9d9011c25c80149eb88318e7f50d0e/pymodbus/client/mixin.py#L719
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for Pymodbus 3.8 to replace depreciated functions.