Items table func #15
Open
Items table func #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonalsk
force-pushed
the
ItemsTableFunc
branch
from
8080d53 to
79c0d8a
Compare
sonalsk
force-pushed
the
ItemsTableFunc
branch
from
79c0d8a to
3b12b97
Compare
sakshivij
reviewed
Feb 2, 2020
| private ItemDBC itemDBC; | ||
|
|
||
| public void init() { | ||
| String jdbcURL = getServletContext().getInitParameter("jdbcURL"); |
There was a problem hiding this comment.
Init is not needed. You can craete a default constructor of the servlet and call getConnection function
Connection con = itemDBC.getConnection();
sakshivij
reviewed
Feb 2, 2020
| private static String jdbcPassword; | ||
| private static Connection jdbcConnection; | ||
|
|
||
| public ItemDBC(String jdbcURL, String jdbcUsername, String jdbcPassword) { |
There was a problem hiding this comment.
Ome way to do is to create a default contsructor and create a separate properties files to define the jdbc url, username or password.
Otherwise you can directly assign values
public ItemDBC(){
this.jdbcURL = " Manually define here the url"
}
sakshivij
reviewed
Feb 2, 2020
|
|
||
| protected void doGet(HttpServletRequest request, HttpServletResponse response) | ||
| throws ServletException, IOException { | ||
| String action = request.getServletPath(); |
There was a problem hiding this comment.
Create a session variable on your JSP instead and just get the value from that page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created Controller Servlet