Refactor GitHub release workflows #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor GitHub release workflows in order to comply with branch protection
rules. The new process:
1. Run the "Create new release PR" manually, selecting the release type
("major", "minor", or "patch"). This will create a new branch
including the Changelog update and the version bumo on the readme,
create-block-theme.php, and package.json files.
2. Merging the PR created on the previous step will trigger the deploy
workflow, which remains unchanged, except for the conditions added in
order for it to run only if the merged PR matches the characteristics of
automated release PR.
1. Fork this repo
2. Checkout this branch
3. Merge intro trunk on the fork
4. Run the workflow, a new PR should be created on the fork
5. Merge the PR; the automated deploy step will run. At this point, the
only thing that you'll be able to test on the fork is that the deploy
workflow correctly identifies the PR and branch as a new release. The
deploy itself requires credentials only available on the parent repo.
* add block themers as reviewers
* prefix tag with v
vcanales
force-pushed
the
update-release-workflow
branch
from
925e21c to
f6e562c
Compare
|
I can confirm that the branch is created as expected, versioning is updated and changelog is created as expected. 
The error noted that both title and body are required, and I see that both are provided so I'm not sure what's actually wrong. |
added 2 commits
April 9, 2024 10:36
|
I have confirmed that this workflow works as expected per the instructions. Using a forked repository I got all the way to "Deploy to Wordpress" when merging the branch created with the workflow (which failed as noted should be expected due to no credentials on my fork... which was good since it was just a test run anyway. :) ) |
pbking
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor GitHub release workflows in order to comply with branch protection rules.
Also removes google fonts related workflow.
The new process
Testing instructions