Publish rich text build types #49651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
requested review from
ellatrix,
fluiddot,
dcalhoun and
ajitbohra
as code owners
noahtallen
commented
Apr 7, 2023
noahtallen
commented
Apr 7, 2023
noahtallen
commented
Apr 7, 2023
noahtallen
commented
Apr 7, 2023
noahtallen
commented
Apr 7, 2023
|
Components changelog shouldn't be required for these tweaks, but let me know :) |
|
Size Change: +13 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in eceb797. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4634353443
|
tyxla
reviewed
Apr 7, 2023
There was a problem hiding this comment.
Thanks for working on this 👍
It's looking great overall, my only concern is related to the subtle way we introduce circular dependencies.
I'd also suggest adding a CHANGELOG entry, since this would be a breaking change for anyone who uses the DT version for typing this package. It will likely need an entry in the @wordpress/components CHANGELOG as well.
You're definitely right, but the main reason I didn't do that is because I wanted to avoid deeper changes to how things work in these packages. The second part of that consideration is that the original rich-text files are still in JS (and typed via JSDoc). While having the types different in two different places is not a good place to be, it has already been the case for a while.
I'm also not convinced we are introducing a circular dependency -- from what I can tell, I mean, basically, components doesn't import any type information from Definitely not saying this situation is ideal, but I personally don't think this should be a blocker. However, I'll explore moving those rich text types, and if it's straight forward, I'll add that :) |
noahtallen
force-pushed
the
publish-rich-text-build-types
branch
from
eceb797 to
df8a301
Compare
noahtallen
commented
Apr 13, 2023
noahtallen
commented
Apr 13, 2023
noahtallen
added
[Type] Build Tooling
noahtallen
force-pushed
the
publish-rich-text-build-types
branch
2 times, most recently
from
c0b7fea to
45b1155
Compare
noahtallen
commented
Apr 20, 2023
tyxla
force-pushed
the
publish-rich-text-build-types
branch
2 times, most recently
from
4e625b1 to
15b401a
Compare
|
I've just pushed another commit to fix a couple of wrong imports that were breaking the package TS build. Going to take a thorough look now. |
tyxla
approved these changes
Apr 28, 2023
There was a problem hiding this comment.
Looking great from my perspective 👍
Thank you @noahtallen, great work as always 🚀
|
Might need another rebase since the failures don't seem related, but they seem to persist. |
noahtallen
force-pushed
the
publish-rich-text-build-types
branch
from
5acaa3f to
bbe2723
Compare
|
The Puppeteer 3 suite seems to be failing across all commits right now, unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Publish rich text build types.
Why?
See #49647
How?
Add the tsconfig and fix any issues that came up! There were one or two mismatches between components and rich text, and I don't think my fixes should break anything
Testing Instructions
CI