Add optional chain to sizes indexing of media details in edit-site #68995
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This optional chaining is already present in 21 other lines in Gutenberg where
sizes
(inmedia_details
) is indexed, but is missing on these two lines.Why?
For some reason,
media_details
is an empty object for some of my attachments on my site, so this throws a TypeError. This change resolves this issue.How?
?.
is optional chaining to short circuit before the TypeError.Testing Instructions
I don't actually know how some attachments don't have media_details on my site in the first place. I tried to reproduce on a playground with some hooks from the real site, e.g.
/wp-admin/site-editor.php?postType=page
to trigger the page thumbnails to be shown in the list, which triggers this code path and throws the TypeError without this change.n/a from PR template
Testing Instructions for Keyboard
n/a
Screenshots or screencast
n/a