Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional chain to sizes indexing of media details in edit-site #68995

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

grgar
Copy link

@grgar grgar commented Feb 1, 2025

What?

This optional chaining is already present in 21 other lines in Gutenberg where sizes (in media_details) is indexed, but is missing on these two lines.

Why?

For some reason, media_details is an empty object for some of my attachments on my site, so this throws a TypeError. This change resolves this issue.

How?

?. is optional chaining to short circuit before the TypeError.

Testing Instructions

I don't actually know how some attachments don't have media_details on my site in the first place. I tried to reproduce on a playground with some hooks from the real site, e.g.

add_filter( 'intermediate_image_sizes', '__return_empty_array' );
  1. Make attachment(s) which don't cause media_details to be set (see above).
  2. Create a page and set one of these attachments as the featured image of the page.
  3. Open /wp-admin/site-editor.php?postType=page to trigger the page thumbnails to be shown in the list, which triggers this code path and throws the TypeError without this change.
n/a from PR template

Testing Instructions for Keyboard

n/a

Screenshots or screencast

n/a

Copy link

github-actions bot commented Feb 1, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: grgar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Feb 1, 2025

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @grgar! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 1, 2025
This optional chaining is already present in 21 other lines in Gutenberg where `sizes` (in `media_details`) is indexed, but is missing on these two lines.

For some reason, `media_details` is an empty object for some of my attachments on my site, so this throws a TypeError. This change resolves this issue.

Co-authored-by: grgar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant