Remove block icon from InstalledBlocksPrePublishPanel. #69046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
|
Size Change: -124 B (-0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in dd10a65. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13158257836
|
Mamaduka
reviewed
Feb 5, 2025
| @@ -13,6 +13,7 @@ import InstalledBlocksPrePublishPanel from './installed-blocks-pre-publish-panel | |||
| import getInstallMissing from './get-install-missing'; | |||
|
|
|||
| registerPlugin( 'block-directory', { | |||
| icon: undefined, | |||
There was a problem hiding this comment.
Do you mind adding a small inline comment here so it's not reverted in the future?
Mamaduka
approved these changes
Feb 5, 2025
afercia
deleted the
fix/remove-block-icon-from-InstalledBlocksPrePublishPanel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #68688
See #69045
When a block is installed from the block directory,
InstalledBlocksPrePublishPanelrenders a panel in the pre-publish sidebar with information about the newly installed block.This panel also shows a
blockicon that doesn't add value and is inconsistent with its intended usage.Under the hood, it uses
PluginPrePublishPanel. In fact, the block-directory is registered as a plugin. However,PluginPrePublishPanelis intended to show an icon for external plugins. #53302 introduced simple logic to 1) render an icon if passed 2) otherwise show the icon registered with the plugin. The intent is to show an icon to make users understand the panel is added by a plugin.In this case the panel is added by the editor core though. It's an editor feature and it should not show a meaningless, unnecessary,
blockicon.Why?
The editor should not show unnecessary, confusing, icons.
How?
undefinedin theblock-directoryplugin registration.iconprop specifically passed to the block directoryInstalledBlocksPrePublishPanel.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast