Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block directory: Some error messages show the Try reloading the page. string twice #69056

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

Mukulsingh27
Copy link

@Mukulsingh27 Mukulsingh27 commented Feb 5, 2025

What?

Closes: #69048

  • This PR resolves the issue of duplicate error messages by preventing the redundant appending of the Try reloading the page string when displaying the notice for fatal errors when installing a new block via the block directory. It ensures that the message is clear and concise, without unnecessary repetition.

Why?

How?

  • It removes the duplicated message by eliminating the code responsible for appending the same string when displaying the message for a fatal error

Testing Instructions

  • TBH, Not sure how to provide instructions other than altering the code to trigger some errors.

Screenshots or screencast

Before After
Before After

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 5, 2025
Copy link

github-actions bot commented Feb 5, 2025

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Mukulsingh27! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@Mukulsingh27 Mukulsingh27 marked this pull request as ready for review February 5, 2025 17:12
Copy link

github-actions bot commented Feb 5, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mukulsingh27 <[email protected]>
Co-authored-by: afercia <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mukulsingh27 Mukulsingh27 changed the title Fix: Fix duplicated error message by removing redundant append Block directory: Some error messages show the Try reloading the page. string twice Feb 5, 2025
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Feature] Block Directory Related to the Block Directory, a repository of block plugins labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Directory Related to the Block Directory, a repository of block plugins First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block directory: Some error messages show the Try reloading the page. string twice
2 participants