Query block: Add option to ignore sticky posts behavior #69057
Merged
+36
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
Mamaduka
requested review from
spacedmonkey,
ajitbohra and
fabiankaegy
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @keithdevon. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +56 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
add/query-block-ignore-sticky-posts
branch
from
f35424e to
fd5300e
Compare
|
Flaky tests detected in 04e6c1d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13173131309
|
Mamaduka
commented
Feb 6, 2025
| if ( inherit ) { | ||
| // Change the post-type if needed. | ||
| if ( templateSlug?.startsWith( 'archive-' ) ) { | ||
| query.postType = templateSlug.replace( 'archive-', '' ); | ||
| postType = query.postType; | ||
| currentPostType = query.postType; |
There was a problem hiding this comment.
Unrelated, this just fixes the ESLint warning.
carolinan
approved these changes
Feb 7, 2025
|
Thanks for testing, @carolinan 🙇
I read it as a general description of sticky posts. But yeah, it can be confusing. Do you think the help text should reflect the currently selected option? Maybe @afercia can recommend a better alternative. |
|
I was thinking more about this, and the help text seems okay. It describes how sticky posts generally work and isn't specific to the options; those hints are part of the options labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #66221.
Alternative to #66222.
PR adds a new option for the Query block's sticky post setting: "Ignore," which doesn't prepend sticky posts at the top but displays them in the natural order of the query.
It's the same as setting
ignore_sticky_poststotrueforWP_Query.Why?
Makes the Query block more consistent with the front end.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2025-02-05.at.20.19.47.mp4