Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover Block: Show settings inspector controls in the Site Editor #69178

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

pranvinit
Copy link

@pranvinit pranvinit commented Feb 13, 2025

What?

  1. The Cover block was not showing the Settings inspector controls in the Site Editor.

Why?

  1. Because the url attribute was undefined for featured image (fetched contextually in the post) when editing a template.

How?

  1. Extend the condition to show the Settings inspector controls if the user is editing a template.

Testing Instructions

  1. Edit a template (e.g., a Single Post template) in the Site Editor.
  2. Add a Cover block.
  3. Switch the image source to "Use Featured Image" → The Fixed Background option is now available.

Resolves: #69179

Screenshots or screencast

Screen.Recording.2025-02-13.at.2.10.39.PM.mov

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: pranvinit <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 13, 2025
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @pranvinit! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Featured Image on Covers does not have controls to fix image
2 participants