Update check for index.php #424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Out of the two pull requests for this issue, I prefer this solution, but we also need to check for block-templates/index.html. |
|
@carolinan this one can't possibly work, it will return true if you have index.php in any of the theme folders and the |
|
Got it, that makes perfect sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #422. This PR updates the theme check to check for both
index.phportemplates/index.html, since WordPress themes are no longer required to have a index.php file: https://core.trac.wordpress.org/changeset/52940(Started this PR at WCEU Contributor Day, I haven't had a chance to test this yet!)