Remove index php requirement #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From WordPress 6.0, index.php file is optional. Theme will work without that file too. This PR will remove "REQUIRED: Could not find the file index.php in the theme."
Checked the required requirement of index.php from block themes
|
This is for #422 The code works, but it needs to follow the Code Standards |
carolinan
reviewed
Jun 18, 2022
checks/class-file-check.php
Outdated
| @@ -68,6 +68,19 @@ public function check( $php_files, $css_files, $other_files ) { | |||
|
|
|||
| $musthave = array( 'index.php', 'style.css', 'readme.txt' ); | |||
|
|
|||
| $fse_find = array_filter( array_keys( $other_files ), function( $file_name ) { | |||
| if ( false !== stripos( $file_name, 'templates/index.html' ) || false !== stripos( $file_name, 'block-templates/index.html' ) ) { | |||
| return true; | |||
There was a problem hiding this comment.
Will this not return true for the exception that was brought up on Trac here: https://core.trac.wordpress.org/ticket/54910,
classic themes that has a templates folder with a "silence is golden" index.html file.
There was a problem hiding this comment.
It probably will :-) but I haven't seen any themes adding it in that way
We could probably add in the mix a check for the full-site-editing tag, but it's not future proof...
There was a problem hiding this comment.
wp_is_block_theme has similar implementation.
acosmin
approved these changes
Jul 20, 2022
them-es
added a commit
to them-es/starter-fse
that referenced
this pull request
Oct 1, 2022
FSE block themes can be activated without index.php https://core.trac.wordpress.org/ticket/54272 WordPress/theme-check#425
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will remove the REQUIRED index.php file from block themes. From WordPress 6.0, index.php file is optional in Block themes.