Mu-plugins: Add margin to fixed navigation on sites with the latest event banner #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might be better to assume that some sites have a fixed top nav, and just place this banner somewhere below that - I do wonder about the effectiveness of such an element though, and perhaps we'd be best with something more obvious? |
renintw
force-pushed
the
fix/1098-latest-site-fixed-navivagtion-fix
branch
from
41d4d90
to
847b4f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution to the linked issue is not really easy, since different WordCamp themes use very different markup and CSS to make the navigation fixed. There is also no way to change the reference point for a fixed positioned element.
This PR will introduce some JavaScript that searches for any
<nav>item withposition: fixedand adds a CSS class, that is than used in the existing CSS selector pushing down the navigation as well.Fixes #1098
Screenshots
This is how the pages look like with this PR applied (compared to #1098):