Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Theme browser horizontal overflow in mobile layout #7791

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

himanshupathak95
Copy link

@himanshupathak95 himanshupathak95 commented Nov 13, 2024

Trac ticket: Core - 62411

This PR fixes a UI issue where the theme browser creates unwanted horizontal scrolling on mobile devices. The issue occurs specifically when viewing theme details in the mobile layout.

When viewing theme details in mobile layout:

  • Theme screenshot causes horizontal overflow
  • Right margin extends beyond viewport
  • Creates unnecessary horizontal scrolling
  • Impacts mobile user experience

Solution

  • Adjusted the theme screenshot container margins to ensure content stays within viewport bounds while maintaining the design integrity.

Screenshots

Before Fix
Before Fix (1)

Resolves horizontal scrolling issue in theme browser on mobile devices
by adjusting image container margins. This ensures the theme details
modal stays within viewport bounds.
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props abcd95.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant