Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance _wp_after_delete_font_family() performance using the fields argument in `get_children() #8407

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Enhance _wp_after_delete_font_family() performance using the fields argument in `get_children() #8407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/wp-includes/fonts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,15 +219,16 @@ function _wp_after_delete_font_family( $post_id, $post ) {
return;
}

$font_faces = get_children(
$font_faces_ids = get_children(
array(
'post_parent' => $post_id,
'post_type' => 'wp_font_face',
'fields' => 'ids',
)
);

foreach ( $font_faces as $font_face ) {
wp_delete_post( $font_face->ID, true );
foreach ( $font_faces_ids as $font_faces_id ) {
wp_delete_post( $font_faces_id, true );
}
}

Expand Down
Loading