Merge pull request #13 from robbecker-wf/strong_mode

HY-4964 Turn on strong mode and lint rules

.gitignore

@@ -4,5 +4,5 @@
 /.pub
 packages
 /pubspec.lock
-
+node_modules
 /coverage

analysis_options.yaml

@@ -0,0 +1,7 @@
+analyzer:
+  strong-mode: true
+
+linter:
+  rules:
+    - cancel_subscriptions
+    - close_sinks

example/echo.dart

@@ -2,7 +2,7 @@ library echo;
 
 import "dart:html";
 import 'package:logging/logging.dart';
-import "package:sockjs_client/sockjs.dart" as SockJS;
+import "package:sockjs_client/sockjs_client.dart" as SockJS;
 
 DivElement div  = querySelector('#first div');
 InputElement inp  = querySelector('#first input');

lib/src/ajax.dart

@@ -119,9 +119,13 @@ class XHRLocalObject extends AbstractXHRObject {
     }
 }
 
-XHRLocalObjectFactory(method, baseUrl, {bool noCredentials, payload}) => new XHRLocalObject(method, baseUrl, noCredentials: noCredentials, payload: payload);
+AbstractXHRObject XHRLocalObjectFactory(String method, String baseUrl, {bool noCredentials, payload}) {
+  return new XHRLocalObject(method, baseUrl, noCredentials: noCredentials, payload: payload);
+}
 
-XHRCorsObjectFactory(method, baseUrl, {bool noCredentials, payload}) => new XHRCorsObject(method, baseUrl, noCredentials: noCredentials, payload: payload);
+AbstractXHRObject XHRCorsObjectFactory(String method, String baseUrl, {bool noCredentials, payload}) {
+  return new XHRCorsObject(method, baseUrl, noCredentials: noCredentials, payload: payload);
+}
 
 // 1. Is natively via XHR
 // 2. Is natively via XDR

lib/src/info.dart

@@ -133,9 +133,11 @@ class InfoReceiverFake extends InfoReceiver {
 class WInfoReceiverIframe {
   WInfoReceiverIframe(ri, _trans_url, baseUrl) {
     var ir = new AjaxInfoReceiver(baseUrl, XHRLocalObjectFactory);
-    ir.onFinish.listen( (evt) {
+    ir.onFinish.listen( (event.Event evt) {
+      if (evt is InfoReceiverEvent) {
         ri._didMessage('m${JSON.encode([evt.info, evt.rtt])}');
-        ri._didClose();
+      }
+      ri._didClose();
     });
   }
   doCleanup() {}

lib/src/transport/receiver-xhr.dart

@@ -39,4 +39,6 @@ part of sockjs_client;
   }
 }
 
-XhrReceiverFactory(String recvUrl, AjaxObjectFactory xhrFactory, {bool noCredentials}) => new XhrReceiver(recvUrl, xhrFactory, noCredentials: noCredentials);
+Receiver XhrReceiverFactory(String recvUrl, AjaxObjectFactory xhrFactory, {bool noCredentials}) {
+  return new XhrReceiver(recvUrl, xhrFactory, noCredentials: noCredentials);
+}

lib/src/transport/sender.dart

@@ -112,7 +112,7 @@ class JsonPGenericSender {
     }
     form.submit();
 
-    var readyStateChangeHandler = (e) {
+    var readyStateChangeHandler = (html.Event e) {
       if (new JsObject.fromBrowserObject(iframe)["readyState"] == 'complete') completed(null);
     };
 

pubspec.yaml

@@ -9,9 +9,9 @@ dependencies:
   browser: '>=0.9.0 <1.0.0'
   logging: '>=0.9.0 <1.0.0'
 dev_dependencies:
-  coverage: '^0.7.3'
+  coverage: '>=0.7.3 < 1.0.0'
   dart_dev: '^1.0.0'
-  dart_style: '^0.2.0'
-  test: '>=0.12.5'
+  dart_style: '>=0.2.0 < 1.0.0'
+  test: '>=0.12.5 < 1.0.0'
 environment:
-  sdk: '>=1.0.0 <2.0.0'
+  sdk: '>=1.0.0 <2.0.0'

smithy.yaml

@@ -1,11 +1,11 @@
 project: dart
 language: dart
 
-# dart 1.19.1
-runner_image: drydock-prod.workiva.org/workiva/smithy-runner-generator:92530
+runner_image: drydock-prod.workiva.net/workiva/smithy-runner-generator:165358 # 62.0.0
 
 script:
   - pub get
+  - pub run dart_dev analyze
 
 artifacts:
   build:

test/xhr_streaming_test.dart

@@ -46,7 +46,10 @@ void main() {
 }
 
 
-MockXHRCorsObjectFactory(String method, String baseUrl, {bool noCredentials, payload}) => new MockXHRCorsObject();
+AbstractXHRObject MockXHRCorsObjectFactory(String method, String baseUrl, {bool noCredentials, payload}) {
+  return new MockXHRCorsObject();
+}
+
 class MockXHRCorsObject extends AbstractXHRObject {
   MockXHRCorsObject();
 }

tool/dev.dart

@@ -1,15 +1,15 @@
 library tool.dev;
 
 import 'dart:async';
-import 'dart:io';
-
 import 'package:dart_dev/dart_dev.dart' show dev, config;
 import 'package:dart_dev/util.dart' show TaskProcess, reporter;
 
 main(List<String> args) async {
   // https://github.com/Workiva/dart_dev
 
-  config.analyze.entryPoints = ['example/', 'lib/', 'tool/'];
+  config.analyze
+    ..entryPoints = ['example/', 'lib/', 'tool/']
+    ..strong = true;
   config.format.directories = ['example/', 'lib/', 'tool/'];
 
   config.coverage