add sockjs connect span #440
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Establishing a web socket connection incurs 750 ms of latency during initial app load. This is a large amount of time that we should capture via traces to help categorize opportunities of improvement based on impact.
Additionally, adding the chosen transport as an attribute will help guide future decisions w.r.t. browser messaging.
Changes
I added a span encompassing the duration it takes to establish a SockJS connection (usually a web socket connection). The span gets an attribute that's the chosen transport.
I also cleaned up the connect logic. We have a timeout parameter we aren't using that can apply to the info request of SockJS. SockJS has its own timeouts, but they don't pertain to the initial info request.
Testing/QA Instructions
Pull the changes into a wdesk build and load an experience.