Visibility fixes for raid and party frames solo Closes #391

Wutname1 · Sep 6, 2024 · a997646 · a997646
1 parent e9ba325
commit a997646
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -474,7 +474,8 @@
     "ObjectiveTrackerFrame",
     "RENOWN_LEVEL_LABEL",
     "STANDING",
-    "UNKNOWN"
+    "UNKNOWN",
+    "UnregisterAttributeDriver"
   ],
   "Lua.workspace.ignoreDir": [".vscode", "libs/*"],
   "Lua.diagnostics.enable": true,

diff --git a/Modules/UnitFrames/Options.lua b/Modules/UnitFrames/Options.lua
@@ -938,6 +938,7 @@ function Options:AddGroupDisplay(frameName, OptionSet)
 			UF.DB.UserSettings[UF.DB.Style][frameName][setting] = val
 			--Update the screen
 			UF.Unit:Get(frameName).header:SetAttribute(setting, val)
+			UF.Unit:Get(frameName):UpdateAll()
 		end,
 		args = {
 			showRaid = {

diff --git a/Modules/UnitFrames/SpawnFrames.lua b/Modules/UnitFrames/SpawnFrames.lua
@@ -240,15 +240,14 @@ function UF:SpawnFrames()
 				local firstElement = groupElement.header or groupElement.frames[1] or groupElement
 				if firstElement then
 					local function GroupFrameUpdateAll(groupFrame)
+						UnregisterAttributeDriver(firstElement, 'state-visibility')
 						if VisibilityCheck(frameName) and UF.CurrentSettings[frameName].enabled then
-							if firstElement.visibility then RegisterStateDriver(firstElement, firstElement.visibility) end
 							firstElement:Show()
 
-							for i, f in pairs(groupFrame.frames) do
+							for _, f in pairs(groupFrame.frames) do
 								if f.UpdateAll then f:UpdateAll() end
 							end
 						else
-							UnregisterStateDriver(firstElement, 'visibility')
 							firstElement:Hide()
 						end
 					end