Iterative Bayesian 3D (t, x, y) S2 merging #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dachengx
commented
Jan 10, 2025
…1521) * Reduce storage usage by creating new `data_type` `enhanced_peaklet_classification_dtype` * Constraint boundaries
dachengx
added a commit
to XENONnT/axidence
that referenced
this pull request
Jan 15, 2025
juehang
reviewed
Jan 16, 2025
3 tasks
dachengx
added a commit
to XENONnT/axidence
that referenced
this pull request
Feb 7, 2025
* Compatible with XENONnT/straxen#1513 * Inherit `find_n_competing`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible
Depends on AxFoundation/strax#946 and AxFoundation/strax#951
Combining #1495 and #1512.
What does the code in this PR do / what does it improve?
Merge S2 based on the probability that the two peaklets are from the same normal distribution.
The
FAKE_MERGED_S2_TYPEwas introduced by #36 to handle cases that the very old strax can not handle correctly. So it is removed.Can you briefly describe how it works?
For more details please refer to https://xe1t-wiki.lngs.infn.it/doku.php?id=xenon:xenonnt:analysis:s2_merging_time_position.
Can you give a minimal working example (or illustrate with a figure)?
Please include the following if applicable:
Notes on testing
All italic comments can be removed from this template.