Fixes for gcc 13 #1128
Merged
Fixes for gcc 13 #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bronek
commented
Jan 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1128 +/- ##
===========================================
+ Coverage 54.11% 59.74% +5.63%
===========================================
Files 187 208 +21
Lines 9942 10493 +551
Branches 5283 5589 +306
===========================================
+ Hits 5380 6269 +889
+ Misses 3561 2635 -926
- Partials 1001 1589 +588 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes compilation errors in gcc-13 by adding
#include <cstdint>where needed and explains how to avoid compilation errors inrocksdbfrom conan with this compiler.There's also a drive-by addition of
.devcontainerto.gitignore