Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Structure global validators better #1484

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

yinyiqian1
Copy link
Collaborator

@yinyiqian1 yinyiqian1 commented Jun 24, 2024

refactor: #1170 Structure global validators better

@yinyiqian1 yinyiqian1 marked this pull request as draft June 24, 2024 04:23
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 35.18519% with 35 lines in your changes missing coverage. Please review.

Project coverage is 67.86%. Comparing base (b2eacf9) to head (8e6fd49).

Files Patch % Lines
src/rpc/handlers/LedgerEntry.hpp 35.71% 4 Missing and 5 partials ⚠️
src/rpc/handlers/BookOffers.hpp 44.44% 0 Missing and 5 partials ⚠️
src/rpc/handlers/GetAggregatePrice.hpp 40.00% 0 Missing and 3 partials ⚠️
src/rpc/handlers/AccountChannels.hpp 0.00% 2 Missing ⚠️
src/rpc/handlers/AccountLines.hpp 50.00% 0 Missing and 2 partials ⚠️
src/rpc/handlers/DepositAuthorized.hpp 0.00% 2 Missing ⚠️
src/rpc/handlers/AccountCurrencies.hpp 0.00% 1 Missing ⚠️
src/rpc/handlers/AccountNFTs.hpp 0.00% 1 Missing ⚠️
src/rpc/handlers/AccountObjects.hpp 0.00% 1 Missing ⚠️
src/rpc/handlers/AccountOffers.hpp 0.00% 1 Missing ⚠️
... and 8 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1484      +/-   ##
===========================================
+ Coverage    67.81%   67.86%   +0.05%     
===========================================
  Files          233      233              
  Lines         9423     9438      +15     
  Branches      5256     5256              
===========================================
+ Hits          6390     6405      +15     
  Misses        1654     1654              
  Partials      1379     1379              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yinyiqian1 yinyiqian1 changed the title Structure global validators better refactor: Structure global validators better Jun 24, 2024
@yinyiqian1 yinyiqian1 marked this pull request as ready for review June 25, 2024 14:24
@yinyiqian1 yinyiqian1 assigned yinyiqian1 and unassigned yinyiqian1 Jun 26, 2024
@yinyiqian1 yinyiqian1 force-pushed the refactor_validators branch from 62919a4 to a3c7e97 Compare June 27, 2024 00:37
@yinyiqian1 yinyiqian1 force-pushed the refactor_validators branch from a3c7e97 to 8e6fd49 Compare June 27, 2024 00:45
@yinyiqian1 yinyiqian1 merged commit 2ff51ff into XRPLF:develop Jun 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants