Feature/issues 163 #164
Closed
Feature/issues 163 #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge latest
…he user wants the toggle to be active from a certain date)
unaizorrilla
added
bug
|
Hi @Kronos11 I'm on vacation! let me some days to check and review this PR |
|
Accidentally deleted this branch re-opening, no worries and enjoy your vacation |
|
@unaizorrilla Any thoughts on this? I understand if you would want to maybe just have a different Toggle for this, but it made sense if you don't put an end time on your toggle you would want it to go on until it was turned off. |
|
Well, I can try to add new toggle for 4.X, this is not a breaking change and can be added easly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds in a default "To" value for the FromToToggle of DateTime.MaxValue
The idea is that the user wants the Toggle to be active from a point in time until it's disabled.