-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dealing with adds #651
Comments
Gooday!
After i reading the following i have a hunch that you might be set your pet behaviour to I'm pretty sure that once you pull more then one target with your pet - accidental body pull even - once the primary target dies, your pet should target the next potential enemy as long as your pet behaviour is set to There's a GoapGoal for it called TargetPetTargetGoal, which is purposefully designed to take advantage of the As long as your character class properly extracted, and read by the backend, this Goal should be added. Let me know if the issue still persists. On the other hand, the following is unrelated to the original issue, however two things caught my eye and they might hinder you to have the expected experience with the project.
Such as [14:00:58:754 I] [GoapAgent ] New Plan= Parallel
[14:00:58:773 E] Index was outside the bounds of the array.
System.IndexOutOfRangeException: Index was outside the bounds of the array.
at Core.ActionBarCostReader.Update(IAddonDataProvider reader) in C:\Users\S\Documents\L\L\Core\Actionbar\ActionBarCostReader.cs:line 48
at Core.AddonReader.Update() in C:\Users\S\Documents\L\L\Core\Addon\AddonReader.cs:line 73
at Core.BotController.AddonThread() in C:\Users\S\Documents\L\L\Core\BotController.cs:line 156 In the logs, i saw many negative numbers regarding the actions await times. Like
Where you can see two elapsed milliseconds notice
You can think of it as like a cause and effect.
I could give you a few hints what you can look up like
|
Tyvm for the great answer! Pet is on defensive and he is fighting next mob while we are waiting. I did some changes to code where if our pet has a target and we dont, that we always assist pet, and that seems to work. I fixed the -5 offset aswell but doesnt seem to help. I also tried all the resolutions with different cell sizes. I also looked into the negative numbers and I tested it on 3 different computers they all have negative numbers, and my friend has the same on his computer (I didnt help him to set it up so he must have done exact same mistake). I tested with capping fps to 30, 60, 120 etc, I tried changing hertz and v-sync is also disabled. Im guessing the same bug makes us engage in pvp randomly aswell despite a strict "AllowPvP": false. [10:45:11:659 W] [TargetBlacklist ] (0,17035,MINO) is player or pet! We engage about 30% of enemy players. |
Gooday.
It would be great if you could share the mentioned changes in a PR or just sending a diff about the specific changes, it would help a project a lot.
In the past, i've seen user logs who had similar negative numbers, however i was yet to figure out what would case it. Personally i have never seen such issue, i mean the volume of it, it may happens once of twice but not that consistency what your log presented.
So you are trying to tell me that, even tho the |
CombatGoal.zip
Yes exactly :P We actively engage in pvp. This happens to my friend aswell he added players to the blacklist for a mega scuffed fix. |
If you were kind enough to provide logs where the mentioned issue exists, i might be able to see what went wrong, thanks! |
The above log is from when we engaged a player;
I will save a full log for next time I see him engage in pvp. |
headless_out20250109.log Locals: } 12x BindPad/BindPad.xml:657 Unrecognized XML attribute: bottom 12x BindPad/BindPad.xml:657 Unrecognized XML attribute: top 12x BindPad/BindPad.xml:657 Unrecognized XML attribute: right 12x BindPad/BindPad.xml:657 Unrecognized XML attribute: left 12x BindPad/BindPad.xml:657 Unrecognized XML: AbsInset 12x BindPad/BindPad.xml:656 Unrecognized XML: BackgroundInsets 12x BindPad/BindPad.xml:655 Unrecognized XML attribute: tile 12x BindPad/BindPad.xml:655 Unrecognized XML attribute: edgeFile 12x BindPad/BindPad.xml:655 Unrecognized XML attribute: bgFile 12x BindPad/BindPad.xml:655 Unrecognized XML: Backdrop |
It would be nice if you could attach the first part of the logs, it seems when you were running the project you progressed to "tomorrow" so the yesterday log have not been included. When you start the project there are key information logged about the environment. They are crucial for me to understand whats going on!
That is by design, that element in the frontend only shows images when the screen is getting captured for the NpcNameFinder component. So its not designed to show a real time status of the game. It was a performance choice of mine. I have not yet found a way to stream bitmaps efficiently. Regarding to the Bindpad, just ignore them, they are only warning.
By any chance are you using the custom addon name as It seems blizzard has pushed some changes which prevents On the other hand,
Hah it seems like this issue exists for a long time |
Should be fixed Since #653 |
After #654 i would hope that the blacklist target action going to be respected among the stack. Let me know how it turns out! |
Full log: Testing the new update now!
|
I suspect there might be some Culture related issue. If get it correctly, at your culture the floating point numbers are represented with For mine, we are using |
Maybe its why '=' does not work for me as keybind aswell |
If you want to use the Mentioned in the readme 10.1. Actionbar Key Bindings: |
Though still not dealing with adds. Pet is fighting mob while we wait for him to kill it. |
About that, i haven't had the time to look into it as of yet. Recently some changes where happened in most likely it got broke. |
Still seem to attack players at random, but later we ignored the same player so its an improvement |
Alright thanks for the feedback, the search for new target related code is in a different thread, so i have to find a way to keep them in sync. |
I've did some testing and at my end it works as expected. At the readme i would like to point out two important setup requirement
I'm testing at the Classis Era PTR, with 60lvl hunter, pet is set to
|
Here's another scenario with video 1080_watermark_big.mp4 |
The situation should improve after #659 and 11d6efc I've incorporated your changes, however added extra attention to Pet Based classes. |
After the recent changes, let me know if the issue regarding pulling enemy faction players still persist. |
Description
Wondering what im doing wrong, if my pet pulls 2 mobs we just stand and wait for pet to die or mob to die before we continue.
[13:46:36:496 I] [GoapAgent ] Kill credit detected! Session Total: 7 | Last Combat: 1 | Currently fighting: 1
[13:46:36:529 I] [CombatGoal ] Lost target!
[13:46:36:544 W] [GoapAgent ] New Plan= NO PLAN
I have
Assist Target -> F by default is game settings
Target Pet -> Numpad Multiply has to setup manually
Pet Attack -> Numpad Subtract has to setup manually
This works as if I stop targeting the current target im fighting he retargets via pet instantly.
Gone over the settings many times but im not getting any feedback of what we are trying to do, so im not sure whats happening.
Addon Version
1.7.60
World of Warcraft Client
World of Warcraft Classic
Reproduction Steps
Pull a mob, then pull another, kill first mob, then we know the second target exists but we have no plan.
Last Good Version
No response
Screenshots
No response
Logs
headless_out20241231_003.log
The text was updated successfully, but these errors were encountered: