Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: While FollowRouteGoal active double check whether the unit is valid. #661

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

Xian55
Copy link
Owner

@Xian55 Xian55 commented Jan 11, 2025

Changes:

  • Core: CombatLog: Holds EvadeMobs
  • Core: FollowRouteGoal: When side activity founds new possible target be sure to double check whether is a valid target and check if blacklisted!
  • Core: MouseOverBlacklist: Removed
  • Core: Blacklist: From now on accepts IBlacklistSource(target,mouseover). Replaced linear search with SearchValues when searching for keyword in a name.

Core: FollowRouteGoal: When side activity founds new possible target be sure to double check wheter is a valid target and check if blacklisted!

Core: MouseOverBlacklist: Removed

Core: Blacklist: From now on accepts IBlacklistSource(target,mouseover). Replaced linear search with SearchValues when searching for keyword in a name.
@Xian55 Xian55 added bugfix This pull request fixes an issue. refactor This ticket concerns the possible simplification of code/data. enhancement This pull request implements a new feature. labels Jan 11, 2025
@Xian55 Xian55 linked an issue Jan 11, 2025 that may be closed by this pull request
@Xian55 Xian55 merged commit 57590a1 into dev Jan 11, 2025
1 check passed
@Xian55 Xian55 deleted the fix/651_3 branch January 11, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This pull request fixes an issue. enhancement This pull request implements a new feature. refactor This ticket concerns the possible simplification of code/data.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dealing with adds
1 participant