Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: SharedLib: LineSegmentOperation: bounds check before copying into span #660

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Fix: SharedLib: LineSegmentOperation: bounds check before copying into span #660

merged 1 commit into from
Jan 11, 2025

Conversation

Xian55
Copy link
Owner

@Xian55 Xian55 commented Jan 11, 2025 •
edited
Loading

Changes:

  • CoreTests: Remove unused variables.
  • SharedLib: NpcNameFinder: Increase total capacity by factor of 2 (32 -> 16)

Repro case:

  • Zoom in really close to a given NpcName
    image

@Xian55
CoreTests: Remove unused variables.
fc0ac6e 
SharedLib: LineSegmentOperation: bounds check before copying into span

SharedLib: NpcNameFinder: Increase total capacity by factor of 2 (32 -> 16)
@Xian55 Xian55 added bugfix This pull request fixes an issue. refactor This ticket concerns the possible simplification of code/data. labels Jan 11, 2025
@Xian55 Xian55 merged commit 5a228de into dev Jan 11, 2025
1 check passed
@Xian55 Xian55 linked an issue Jan 11, 2025 that may be closed by this pull request
[NpcNameFinder] Specified argument was out of the range of valid values. #609
Closed
@Xian55 Xian55 deleted the fix/609 branch January 11, 2025 16:55
@Xian55 Xian55 mentioned this pull request Jan 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix This pull request fixes an issue. refactor This ticket concerns the possible simplification of code/data.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NpcNameFinder] Specified argument was out of the range of valid values.
1 participant
@Xian55