-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DF_bandwidth ELF flow #8782
Draft
Json288
wants to merge
9
commits into
Xilinx:master
Choose a base branch
from
Json288:elf
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
DF_bandwidth ELF flow #8782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jamesong <[email protected]>
Signed-off-by: jamesong <[email protected]>
Json288 - is not a collaborator |
Can one of the admins verify this patch? |
ok to test |
Signed-off-by: jamesong <[email protected]>
Merge master to elf
Signed-off-by: jamesong <[email protected]>
…right info Signed-off-by: jamesong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Added ELF flow for DF_bandwidth test, and a hidden sub-cmd --elf for xrt-smi validate.
How problem was solved, alternative solutions (if any) and why they were rejected
Added a variable and functions in XBUtilitiesCore to check if --elf option is used.
DF_bandwidth test would check this variable to decide whether to use ELF flow.
Enabled querying for the new xclbin and elf files for DF_bandwidth ELF flow.
What has been tested and how, request additional testing if necessary
Tested all available benchmarks on strix b0 with and without --elf.
Needs to test if codes for ELF flow would cause performance drop in DF_bandwidth.