Pre-generate header/doc files based on isa-spec.yaml #65
+3,999
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When isa-spec.yaml is updated, pre-generated files must be recreated
through isa-spec-gen target.
```
cmake --build . --config Release --target isa-spec-gen
```
This PR moves the generation from src/cpp/aiebu/src/CMakeLists.txt
into
- specification/CMakeLists.txt and
- specification/{aie2,aie2ps}/CMakeLists.txt
The pre-generated files are created in the source tree where they are
checked in.
The isa-spec-gen target is not invoked as part of a regular build, but
can be run by specifying the target. If the files are different they
will have to be added and comitted along with the new isa-spec.yaml file.
Still to-do is to have a default target that compare the timestamp of
isa-spec.yaml against that of the pre-generated files.
Signed-off-by: Soren Soe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When isa-spec.yaml is updated, pre-generated files must be recreated through isa-spec-gen target.
This PR moves the generation from src/cpp/aiebu/src/CMakeLists.txt into
The pre-generated files are created in the source tree where they are checked in.
The isa-spec-gen target is not invoked as part of a regular build, but can be run by specifying the target. If the files are different they will have to be added and comitted along with the new isa-spec.yaml file.
Still to-do is to have a default target that compare the timestamp of isa-spec.yaml against that of the pre-generated files.