Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error with MSRV and relax MSRV to 1.73 #68

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Sep 15, 2024

a298081 set MSRV to 1.77, but this crate is not actually be able to built with 1.77.

$ cargo +1.77 build
   Compiling rustversion v1.0.17
   Compiling libc v0.2.158
   Compiling cfg-if v1.0.0
   Compiling log v0.4.22
   Compiling generator v0.8.3 (/Users/taiki/projects/forks/others/generator-rs)
error: the `cargo::` syntax for build script output instructions was added in Rust 1.77.0, but the minimum supported Rust version of `generator v0.8.3 (/Users/taiki/projects/forks/others/generator-rs)` is 1.77.
See https://doc.rust-lang.org/cargo/reference/build-scripts.html#outputs-of-the-build-script for more information about build script outputs.
  • First, this PR fixes the above error.
  • Then, the code with the above fix applied is also compatible with 1.73 and later compilers, so this PR also relaxes MSRV to 1.73.

@taiki-e taiki-e changed the title Relax MSRV to 1.73 Fix build error with MSRV and relax MSRV to 1.73 Sep 15, 2024
taiki-e added a commit to tokio-rs/loom that referenced this pull request Sep 15, 2024
@Xudong-Huang Xudong-Huang merged commit a0d202a into Xudong-Huang:master Sep 15, 2024
15 checks passed
@Xudong-Huang
Copy link
Owner

Thanks!

@taiki-e taiki-e deleted the msrv branch September 18, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants