Chores

.golangci.yml

@@ -77,7 +77,6 @@ linters:
   disable-all: true
   enable:
     - bodyclose
-    - deadcode
     #- depguard
     - dogsled
     - dupl
@@ -104,13 +103,11 @@ linters:
     - nolintlint
     - rowserrcheck
     - staticcheck
-    - structcheck
     - stylecheck
     - typecheck
     - unconvert
     - unparam
     - unused
-    - varcheck
     - whitespace
     - asciicheck
     #    - scopelint

cmd/arcdps-log-uploader/ui/textgenerator.go

@@ -84,7 +84,7 @@ func generateMessageTextDiscord(entries []*model.ArcLog, formatOptions FormatOpt
 			currentMessage = currentMessagePlusThisLine
 		}
 	}
-	if len(currentMessage) > 0 {
+	if currentMessage != "" {
 		messages = append(messages, currentMessage)
 	}
 
@@ -159,7 +159,7 @@ func generateMessageTextTeamspeak(entries []*model.ArcLog, formatOptions FormatO
 			currentMessage = currentMessagePlusThisLine
 		}
 	}
-	if len(currentMessage) > 0 {
+	if currentMessage != "" {
 		messages = append(messages, currentMessage)
 	}
 
@@ -177,21 +177,22 @@ func generateMessageTextTeamspeak(entries []*model.ArcLog, formatOptions FormatO
 func headline(title string, dateTime time.Time, multipleDays bool) string {
 	var elements = make([]string, 0)
 	trimmedTitle := strings.TrimSpace(title)
-	if len(trimmedTitle) > 0 {
+	if trimmedTitle != "" {
 		elements = append(elements, trimmedTitle)
 	}
 
 	if !multipleDays {
 		elements = append(elements, dateTime.Format("02.01.2006"))
 	}
 
-	return "**" + strings.Join(elements, " ") + "**"
+	const bold = "**"
+	return bold + strings.Join(elements, " ") + bold
 }
 
 func headlineTeamspeak(title string, dateTime time.Time, multipleDays bool) string {
 	var elements = make([]string, 0)
 	trimmedTitle := strings.TrimSpace(title)
-	if len(trimmedTitle) > 0 {
+	if trimmedTitle != "" {
 		elements = append(elements, trimmedTitle)
 	}
 

cmd/arcdps-log-uploader/ui/ui.go

@@ -448,7 +448,7 @@ func shouldRetryBeAllowed(tv *walk.TableView, m *ArcLogModel) bool {
 func checkBrowsable(tv *walk.TableView, m *ArcLogModel) bool {
 	if len(tv.SelectedIndexes()) == 1 {
 		arcLog := m.items[tv.SelectedIndexes()[0]]
-		if arcLog.Status == model.Done && arcLog.Report != nil && len(arcLog.Report.Permalink) > 0 {
+		if arcLog.Status == model.Done && arcLog.Report != nil && arcLog.Report.Permalink != "" {
 			return true
 		}
 	}

cmd/arcdps-log-uploader/utils/idler.go

@@ -23,7 +23,7 @@ func (i *Idler) Call() {
 	defer i.mu.Unlock()
 
 	now := time.Now()
-	if !i.lastInvocation.Add(i.idleTimeout).After(now) { //nolint:gocritic
+	if !i.lastInvocation.Add(i.idleTimeout).After(now) {
 		i.lastInvocation = now
 
 		go i.invoke()