Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new rune efficiency setting #493

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Foolishmetal
Copy link

Added a new setting that calculates rune efficiency based on SWOP's updated formula.

@Xzandro
Copy link
Owner

Xzandro commented Aug 16, 2023

We already talked about this in Discord, but just so I do not forget.

Personally, I would do the manipulation of the substats directly in the rune-efficiency plugin code (if the new SWOP efficiency setting is enabled of course) and then send that to the function to keep the function clean and without side effects.
Remove getRuneEfficiencySWOP, add a new setting to the existing rune-efficiency plugin, if that setting is enabled manipulate the rune props before sending it to the function.
This way, you have minimal code adjustments, can use an easily accessible settings and no duplicate code.

@Xzandro
Copy link
Owner

Xzandro commented Nov 10, 2023

Is this still being worked on?

antoinebuysse added a commit to antoinebuysse/sw-exporter that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants