Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/admin 관리자 페이지 구현 step2 #10

Merged
merged 13 commits into from
Feb 4, 2025
Merged

Feat/admin 관리자 페이지 구현 step2 #10

merged 13 commits into from
Feb 4, 2025

Conversation

ywj9811
Copy link
Contributor

@ywj9811 ywj9811 commented Feb 4, 2025

🐈 PR 요약

PR 내용 한 줄로 요약
관리자 페이지 구현 step2

✨ PR 상세

PR 상세 내용 개조식으로 작성
테크 스펙 및 스웨거 참고

🚨 참고사항

리뷰어들이 알아야 하거나 알면 좋은 참고사항 작성

✅ 체크리스트

  • Label 지정했나요?
  • 관련 테크스펙 링크 연결했나요?

Summary by CodeRabbit

  • New Features

    • Introduced comprehensive teacher management endpoints enabling multi-criteria search and updates, including filtering by district, subject, university, and gender.
    • Enabled real-time teacher issue updates and alert notifications.
    • Enhanced teacher status displays with localized (Korean) labels for improved clarity.
  • Chores

    • Consolidated geographic information in application forms and updated the database schema.
    • Upgraded dependencies and configured advanced data querying capabilities.

@ywj9811 ywj9811 added the ✨ Feature New feature or request label Feb 4, 2025
@ywj9811 ywj9811 self-assigned this Feb 4, 2025
Copy link

coderabbitai bot commented Feb 4, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The changes add and modify dependencies, DTO records, mapping methods, use case logic, and endpoints to support enhanced teacher management and class matching. New QueryDSL support and a configuration class are introduced. The updates include package restructuring in the parents and matching domains, modifications to entity fields (such as renaming and adding new properties), and updates to enum values from English to Korean. In addition, the SQL migration script has been updated to reflect these schema changes.

Changes

Files Change Summary
build.gradle, .../global/config/querydsl/QuerydslConfig.java Added QueryDSL JPA and Jakarta dependencies; introduced a configuration class to provide a JPAQueryFactory bean.
.../dto/req/TeacherIssueRequest.java, .../dto/req/TeacherSearchRequest.java, .../dto/res/AllFilteringTeacher.java Added new record classes for teacher issue updates and search-related data transfer objects.
.../mapper/AdminMapper.java Updated mapping logic with parameter adjustments and new method mapToAllFilteringTeacherResponse.
.../usecase/AdminInfoUseCase.java, .../usecase/AdminManageUseCase.java, .../service/AdminGetService.java, .../service/AdminUpdateService.java Introduced teacher search and teacher issue update methods; modified alarm talk and district access handling.
.../presentation/AdminController.java Added new endpoints for updating teacher issues and searching teachers.
.../mapper/ClassMatchingMapper.java, .../usecase/ClassMatchingManageUseCase.java, .../domain/entity/ClassMatching.java, .../domain/repository/ClassMatchingRepository.java, .../domain/service/ClassMatchingSaveService.java Introduced class matching mapping and saving logic; renamed the identifier field and updated package organization.
.../dto/req/ApplicationFormRequest.java, .../mapper/ParentsMapper.java, .../usecase/ParentsManageUseCase.java, .../domain/entity/ApplicationForm.java, .../domain/entity/Parents.java, .../service/ParentsUpdateService.java, .../presentation/ParentsController.java Restructured package paths and mapping logic in the parents domain; added district and dong fields to the application form and removed district updates from Parents.
.../usecase/TeacherManageUseCase.java, .../domain/entity/Teacher.java, .../domain/entity/constant/TeacherStatus.java, .../domain/repository/TeacherDslRepository.java, .../domain/repository/TeacherDslRepositoryImpl.java, .../domain/repository/TeacherRepository.java, .../domain/service/TeacherGetService.java, .../domain/service/TeacherUpdateService.java Enhanced teacher-related functionality with a new alarm talk method, message count and issue update methods, and updated the status enum to Korean; introduced QueryDSL-based search capabilities by extending the repository.
src/main/resources/db/migration/V1_202502030415__create_teacher.sql Updated the SQL migration script: added district and dong columns, revised enum values to Korean, and renamed class_matching to class_matching_id.

Sequence Diagram(s)

sequenceDiagram
    participant AC as AdminController
    participant AI as AdminInfoUseCase
    participant AGS as AdminGetService
    participant TR as TeacherRepository
    AC->>AI: searchTeachers(params)
    AI->>AGS: allTeacherBySearch(request)
    AGS->>TR: findAllSearchTeacher(request)
    TR-->>AGS: List<Teacher>
    AGS-->>AI: List<Teacher>
    AI-->>AC: AllFilteringTeacher response
Loading
sequenceDiagram
    participant AC as AdminController
    participant AM as AdminManageUseCase
    participant AG as AdminGetService
    participant AU as AdminUpdateService
    participant T as Teacher
    AC->>AM: updateTeacherIssue(teacherId, request)
    AM->>AG: teacherById(teacherId)
    AG-->>AM: Teacher
    AM->>AU: updateTeacherIssue(Teacher, request.issue)
    AU->>T: updateIssue(issue)
    T-->>AU: Updated Teacher
    AU-->>AM: Confirmation
    AM-->>AC: 200 OK
Loading

Poem

I hop through lines of code so bright,
With fields and methods taking flight.
New records bloom like carrots in spring,
QueryDSL hops in to do its thing.
My rabbit heart leaps with joyful cheer—
A hoppy, code-filled day is here!
🐰🥕✨

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cb3f416 and 48dcb5b.

📒 Files selected for processing (33)
  • build.gradle (1 hunks)
  • src/main/java/com/yedu/backend/admin/application/dto/req/TeacherIssueRequest.java (1 hunks)
  • src/main/java/com/yedu/backend/admin/application/dto/req/TeacherSearchRequest.java (1 hunks)
  • src/main/java/com/yedu/backend/admin/application/dto/res/AllFilteringTeacher.java (1 hunks)
  • src/main/java/com/yedu/backend/admin/application/mapper/AdminMapper.java (3 hunks)
  • src/main/java/com/yedu/backend/admin/application/usecase/AdminInfoUseCase.java (3 hunks)
  • src/main/java/com/yedu/backend/admin/application/usecase/AdminManageUseCase.java (2 hunks)
  • src/main/java/com/yedu/backend/admin/domain/service/AdminGetService.java (3 hunks)
  • src/main/java/com/yedu/backend/admin/domain/service/AdminUpdateService.java (2 hunks)
  • src/main/java/com/yedu/backend/admin/presentation/AdminController.java (3 hunks)
  • src/main/java/com/yedu/backend/domain/matching/application/mapper/ClassMatchingMapper.java (1 hunks)
  • src/main/java/com/yedu/backend/domain/matching/application/usecase/ClassMatchingManageUseCase.java (1 hunks)
  • src/main/java/com/yedu/backend/domain/matching/domain/entity/ClassMatching.java (1 hunks)
  • src/main/java/com/yedu/backend/domain/matching/domain/repository/ClassMatchingRepository.java (1 hunks)
  • src/main/java/com/yedu/backend/domain/matching/domain/service/ClassMatchingSaveService.java (1 hunks)
  • src/main/java/com/yedu/backend/domain/parents/application/dto/req/ApplicationFormRequest.java (1 hunks)
  • src/main/java/com/yedu/backend/domain/parents/application/mapper/ParentsMapper.java (2 hunks)
  • src/main/java/com/yedu/backend/domain/parents/application/usecase/ParentsManageUseCase.java (3 hunks)
  • src/main/java/com/yedu/backend/domain/parents/domain/entity/ApplicationForm.java (2 hunks)
  • src/main/java/com/yedu/backend/domain/parents/domain/entity/Parents.java (0 hunks)
  • src/main/java/com/yedu/backend/domain/parents/domain/entity/constant/Gender.java (1 hunks)
  • src/main/java/com/yedu/backend/domain/parents/domain/service/ParentsUpdateService.java (0 hunks)
  • src/main/java/com/yedu/backend/domain/parents/presentation/ParentsController.java (1 hunks)
  • src/main/java/com/yedu/backend/domain/teacher/application/usecase/TeacherManageUseCase.java (2 hunks)
  • src/main/java/com/yedu/backend/domain/teacher/domain/entity/Teacher.java (2 hunks)
  • src/main/java/com/yedu/backend/domain/teacher/domain/entity/constant/TeacherStatus.java (1 hunks)
  • src/main/java/com/yedu/backend/domain/teacher/domain/repository/TeacherDslRepository.java (1 hunks)
  • src/main/java/com/yedu/backend/domain/teacher/domain/repository/TeacherDslRepositoryImpl.java (1 hunks)
  • src/main/java/com/yedu/backend/domain/teacher/domain/repository/TeacherRepository.java (1 hunks)
  • src/main/java/com/yedu/backend/domain/teacher/domain/service/TeacherGetService.java (2 hunks)
  • src/main/java/com/yedu/backend/domain/teacher/domain/service/TeacherUpdateService.java (1 hunks)
  • src/main/java/com/yedu/backend/global/config/querydsl/QuerydslConfig.java (1 hunks)
  • src/main/resources/db/migration/V1_202502030415__create_teacher.sql (3 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ywj9811 ywj9811 merged commit 7e534bc into develop Feb 4, 2025
1 of 2 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Feb 21, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant