[PC-443] 매치 프로필 누락 요소 및 통일되지 않은 변수명 수정 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-response # Conflicts: # api/src/main/java/org/yapp/domain/match/application/MatchService.java # api/src/main/java/org/yapp/domain/match/presentation/dto/response/MatchProfileBasicResponse.java
Lujaec
requested changes
Jan 31, 2025
|
|
||
| public static MatchProfileBasicResponse fromProfile(Long matchId, Profile profile) { | ||
| String nickname = profile.getProfileBasic().getNickname(); | ||
| LocalDate birthDate = profile.getProfileBasic().getBirthdate(); | ||
| LocalDate now = LocalDate.now(); | ||
| String age = String.valueOf(Period.between(birthDate, now).getYears()); | ||
| Integer age = Period.between(birthDate, now).getYears(); |
There was a problem hiding this comment.
Profilebasic profileBasic = profile.getProfileBasic() 으로 profileBasic 변수를 따로 빼서 값들을 설정하는 것이 어떨까요 ?
ProfileBasic이 수정되는 경우 따로 변수를 빼서 값들을 설정하는 방식이 더 좋아보이기에 제안합니다 !
There was a problem hiding this comment.
좋은 생각인 것 같습니다!
그렇게 하면 코드가 더 깔끔해지겠네요.
수정하겠습니다.
| MatchInfoResponse response = MatchInfoResponse.builder() | ||
| .matchId(matchInfo.getId()) | ||
| .matchStatus(getMatchStatus(userId, matchInfo)) | ||
| .shortIntroduce("") // Deprecated 된 BIO 에서 넣어야하는지? | ||
| .description(matchedUser.getProfile().getProfileBasic() |
There was a problem hiding this comment.
여기도 프로퍼티 참조가 너무 깊게 되는 것 같아서, 따로 변수를 통해 빼고 관리하는 것이 좋아보입니다!
|
수정완료했습니다! |
고생하셨습니다 ! |
Lujaec
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
PC-443
✨ 작업 내용
✅ 체크리스트
🎃 새롭게 알게된 사항
📋 참고 사항