Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PC-000] 프로필 연락처 타입 수정 #39

Merged
merged 3 commits into from
Feb 1, 2025
Merged

[PC-000] 프로필 연락처 타입 수정 #39

merged 3 commits into from
Feb 1, 2025

Conversation

Lujaec
Copy link
Member

@Lujaec Lujaec commented Jan 31, 2025

🔗 관련 이슈

[PC-000]

✨ 작업 내용

  • 연락처를 관리할 때 , key 값에 ContactType을 사용하도록 변경했습니다.
  • 프로필 업데이트 dto 에 흡연, sns 정보 데이터에 NotBlank 제약 조건을 추가했습니다.

✅ 체크리스트

  • 코드가 정상적으로 컴파일되나요?
  • 테스트 코드를 통과했나요?
  • merge할 브랜치의 위치를 확인했나요?
  • Label을 지정했나요?

🎃 새롭게 알게된 사항

📋 참고 사항

  • 코드 리뷰 시 논의가 필요한 사항이나 배포 관련 주의 사항을 추가합니다.

@Lujaec Lujaec requested a review from devchlee12 January 31, 2025 23:57
@Lujaec Lujaec self-assigned this Jan 31, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2025 •
edited
Loading

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 0745d8e.

♻️ This comment has been updated with latest results.

devchlee12
devchlee12 approved these changes Feb 1, 2025
View reviewed changes
Copy link
Member

@devchlee12 devchlee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@Lujaec Lujaec merged commit 0d6ecc6 into develope Feb 1, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devchlee12 devchlee12 devchlee12 approved these changes

Assignees

@Lujaec Lujaec

Labels
리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lujaec @devchlee12