[PC-477] 리프레시 토큰 및 헬스체크 기능 추가 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lujaec
requested changes
Feb 6, 2025
| } catch (Exception e) { | ||
| throw new ApplicationException(SecurityErrorCode.EXPIRED_ACCESS_TOKEN); | ||
| } | ||
| } |
There was a problem hiding this comment.
healCheck 하는 대상은
엑세스 토큰만 가능한 건가요, 아니면 엑세스 토큰과 리프레쉬 토큰 모두 가능한 건가요 ?
컨트롤러부터의 흐름은 2가지 토큰에 대해 가능한거 같은데, 던지는 에러를 보면 아닌것 같습니다 ..
앞단부터 명확하게 토큰을 명시하거나, 던지는 에러코드를 수정해야할 것 같습니다
There was a problem hiding this comment.
음 헬스체크 API는 액세스토큰 헬스체크를 위한 것이긴 한데요.
이왕 이렇게 된거 둘다 가능하게 에러코드 바꾸겠습니다.
api/src/main/java/org/yapp/domain/auth/presentation/dto/request/RefreshTokenRequest.java
Show resolved
Hide resolved
api/src/main/java/org/yapp/domain/auth/presentation/dto/response/RefreshTokenResponse.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/yapp/domain/auth/application/token/RefreshTokenService.java
Outdated
Show resolved
Hide resolved
|
수정 완료했습니다 |
Lujaec
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
PC-477
✨ 작업 내용
✅ 체크리스트
🎃 새롭게 알게된 사항
📋 참고 사항