refactor: add detailed logic for modify album ownership api

YAPP-Github · Nov 23, 2024 · 4308cfa · 4308cfa
1 parent a9378da
commit 4308cfa
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/photo-service/src/main/java/kr/mafoo/photo/exception/AlbumOwnerChangeDeniedException.java b/photo-service/src/main/java/kr/mafoo/photo/exception/AlbumOwnerChangeDeniedException.java
@@ -0,0 +1,7 @@
+package kr.mafoo.photo.exception;
+
+public class AlbumOwnerChangeDeniedException extends DomainException {
+    public AlbumOwnerChangeDeniedException() {
+        super(ErrorCode.ALBUM_OWNER_CHANGE_DENIED);
+    }
+}
diff --git a/photo-service/src/main/java/kr/mafoo/photo/exception/ErrorCode.java b/photo-service/src/main/java/kr/mafoo/photo/exception/ErrorCode.java
@@ -13,6 +13,7 @@ public enum ErrorCode {
     ALBUM_NOT_FOUND("AE0001", "앨범을 찾을 수 없습니다"),
     ALBUM_DISPLAY_INDEX_IS_SAME("AE0002", "옮기려는 대상 앨범 인덱스가 같습니다"),
     ALBUM_OWNER_MISMATCH("AE0003", "앨범의 소유자가 아닙니다"),
+    ALBUM_OWNER_CHANGE_DENIED("AE0004", "공유된 사용자에게만 소유자를 넘길 수 있습니다"),
 
     PHOTO_NOT_FOUND("PE0001", "사진을 찾을 수 없습니다"),
     PHOTO_BRAND_NOT_EXISTS("PE0002", "사진 브랜드가 존재하지 않습니다"),

diff --git a/photo-service/src/main/java/kr/mafoo/photo/service/AlbumService.java b/photo-service/src/main/java/kr/mafoo/photo/service/AlbumService.java
@@ -6,6 +6,7 @@
 import java.util.Comparator;
 import kr.mafoo.photo.domain.AlbumEntity;
 import kr.mafoo.photo.exception.AlbumNotFoundException;
+import kr.mafoo.photo.exception.AlbumOwnerChangeDeniedException;
 import kr.mafoo.photo.exception.SharedMemberNotFoundException;
 import kr.mafoo.photo.service.dto.AlbumDto;
 import kr.mafoo.photo.service.dto.SharedAlbumDto;
@@ -27,6 +28,7 @@ public class AlbumService {
 
     private final SharedMemberQuery sharedMemberQuery;
     private final MemberService memberService;
+    private final SharedMemberCommand sharedMemberCommand;
 
     @Transactional(readOnly = true)
     public Flux<AlbumDto> findAlbumListByMemberId(String memberId, String token) {
@@ -84,8 +86,14 @@ public Mono<AlbumEntity> modifyAlbumNameAndType(String albumId, String newAlbumN
     @Transactional
     public Mono<AlbumEntity> modifyAlbumOwnership(String albumId, String newOwnerMemberId, String requestMemberId) {
         return albumPermissionVerifier.verifyOwnership(albumId, requestMemberId)
-            .flatMap(album -> albumCommand.modifyAlbumOwnership(album, newOwnerMemberId)
-                // TODO : 앨범 내부 사진 소유자를 새로운 앨범 소유자로 변경
+            .flatMap(album -> sharedMemberQuery.findByAlbumIdAndMemberId(albumId, newOwnerMemberId)
+                    .onErrorResume(SharedMemberNotFoundException.class, ex ->
+                        Mono.error(new AlbumOwnerChangeDeniedException())
+                    )
+                    .flatMap(sharedMemberCommand::removeSharedMember)
+                    .then(albumCommand.modifyAlbumOwnership(album, newOwnerMemberId))
+                    .then(sharedMemberCommand.addSharedMember(albumId, String.valueOf(FULL_ACCESS), requestMemberId))
+                    .thenReturn(album)
             );
     }