draft -- make parse_insert() more than 2x as fast #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorry this is benchmarked on some private data ... using a simple script to dump to JSON, gato:~/sandbox/insert-parser-comparison> time python parse.py 10x | md5sum 846d416e653c08b3f1914d4f53f573e9 - python parse.py 10x 1.97s user 0.33s system 99% cpu 2.309 total md5sum 0.03s user 0.01s system 1% cpu 2.309 total gato:~/sandbox/insert-parser-comparison> time python parse.py 10x | md5sum 846d416e653c08b3f1914d4f53f573e9 - python parse.py 10x 1.01s user 0.04s system 99% cpu 1.064 total md5sum 0.03s user 0.01s system 3% cpu 1.063 total I'll try to productionize it at some point. I didn't test with complete=False and stuff.
|
and ... the _group() trick doesn't work on linux, just mac ... def. another reason not to push this yet! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry this is benchmarked on some private data ... using a simple script to dump to JSON,
gato:~/sandbox/insert-parser-comparison> time python parse.py 10x | md5sum
846d416e653c08b3f1914d4f53f573e9 -
python parse.py 10x 1.97s user 0.33s system 99% cpu 2.309 total
md5sum 0.03s user 0.01s system 1% cpu 2.309 total
gato:~/sandbox/insert-parser-comparison> time python parse.py 10x | md5sum
846d416e653c08b3f1914d4f53f573e9 -
python parse.py 10x 1.01s user 0.04s system 99% cpu 1.064 total
md5sum 0.03s user 0.01s system 3% cpu 1.063 total
I'll try to productionize it at some point. I didn't test with complete=False and stuff.