Added checks for adding analyzer and index analyzer when set

Yelp · Feb 4, 2025 · 9e3f0e5 · 9e3f0e5
1 parent 5005762
commit 9e3f0e5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 17 deletions.
diff --git a/src/main/java/com/yelp/nrtsearch/server/field/PrefixFieldDef.java b/src/main/java/com/yelp/nrtsearch/server/field/PrefixFieldDef.java
@@ -48,9 +48,7 @@ public PrefixFieldDef(
   protected void setSearchProperties(FieldType fieldType, Field requestField) {
     fieldType.setOmitNorms(true);
     fieldType.setTokenized(true);
-    if (requestField.getSearch()) {
-      setIndexOptions(requestField.getIndexOptions(), fieldType, IndexOptions.DOCS);
-    }
+    fieldType.setIndexOptions(IndexOptions.DOCS);
   }
 
   @Override

diff --git a/src/main/java/com/yelp/nrtsearch/server/field/TextFieldDef.java b/src/main/java/com/yelp/nrtsearch/server/field/TextFieldDef.java
@@ -52,21 +52,20 @@ public TextFieldDef(
               ? requestField.getIndexPrefixes().getMaxChars()
               : DEFAULT_MAX_CHARS;
       validatePrefix(minChars, maxChars);
+      Field.Builder prefixFieldBuilder =
+          Field.newBuilder()
+              .setSearch(true)
+              .setIndexPrefixes(
+                  IndexPrefixes.newBuilder().setMinChars(minChars).setMaxChars(maxChars).build());
 
-      this.prefixFieldDef =
-          new PrefixFieldDef(
-              getName(),
-              Field.newBuilder()
-                  .setSearch(true)
-                  .setAnalyzer(requestField.getAnalyzer())
-                  .setIndexAnalyzer(requestField.getIndexAnalyzer())
-                  .setIndexPrefixes(
-                      IndexPrefixes.newBuilder()
-                          .setMinChars(minChars)
-                          .setMaxChars(maxChars)
-                          .build())
-                  .build(),
-              context);
+      if (requestField.hasAnalyzer()) {
+        prefixFieldBuilder.setAnalyzer(requestField.getAnalyzer());
+      }
+      if (requestField.hasIndexAnalyzer()) {
+        prefixFieldBuilder.setIndexAnalyzer(requestField.getIndexAnalyzer());
+      }
+
+      this.prefixFieldDef = new PrefixFieldDef(getName(), prefixFieldBuilder.build(), context);
 
       Map<String, IndexableFieldDef<?>> childFieldsMap = new HashMap<>(super.getChildFields());
       childFieldsMap.put(prefixFieldDef.getName(), prefixFieldDef);