nrt_utils support defaultCredentialsProvider #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vim345
approved these changes
Dec 27, 2023
|
Hi @aprudhomme! Just to confirm: how do we apply the change the the tron jobs? |
| @@ -69,12 +69,13 @@ public class DeleteIncrementalSnapshotsCommand implements Callable<Integer> { | |||
|
|
|||
| @CommandLine.Option( | |||
| names = {"-c", "--credsFile"}, | |||
| description = "File holding AWS credentials, uses default locations if not set") | |||
| description = | |||
| "File holding AWS credentials, uses default locations if not set; Will use DefaultCredentialProvider if this is unset.") | |||
There was a problem hiding this comment.
Should the description contain only uses default credential provider chain if this is unset instead of also including uses default locations if not set?
fragosoluana
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RP-9895
Support default credential providers for nrt_utils.
This allows us to use instance profile for AmazonS3.
manual test from dev: https://fluffy.yelpcorp.com/i/mfBgzt5W6T7s6KTNV1n38SpSDRg0gkcm.html
edge case:
When a user want to use default cred-file-path with a non-default profile name:
-c ~/.aws/credentials -p profile-name